PR a repositorio base para corrección - grupo 2#5
Open
LeWricka wants to merge 66 commits into
Open
Conversation
Create label.yml for automatic labeling in all the pull requests
[#5] - Auto labelling workflow
[#2] - Pre-commit hook for PHP Unit Test updated
[] - Update .gitignore
[] - Updated .gitignore
[] - Updated readme.md with git rules
[] - Pre-commit updated
[] - 540 new update for the project
[#11] - Endpoint create wallet cryptocurrency
[] - Project cache files cleanup
[] - Added database migrations and seeders
[] - Updated database migrations and seeders with users table
Closed issue #37 'Create database migations and seeders'
[] - Fixed multiple bugs and improved code quality
[] - Updated README.md
…ravel project'
[] - Multiple bugs fixed in the tests and datasources
[] - Refactor of the code by splitting API functions in different classes and tests
LeWricka
commented
May 30, 2021
| @@ -0,0 +1,33 @@ | |||
| readme: | |||
| php artisan package:discover | ||
| php artisan key:generate | ||
| #- name: Database migation | ||
| # run: | |
Contributor
Author
There was a problem hiding this comment.
No es necesario, eliminadlo
| @@ -0,0 +1,53 @@ | |||
| name: Laravel Validation | |||
| on: | |||
| @@ -24,7 +24,6 @@ public function __invoke(string $email): JsonResponse | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
Este fichero no se utiliza, podríais eliminarlo, no aporta y es lo que viene de ejemplo
| @@ -0,0 +1,16 @@ | |||
| <?php | |||
|
|
|||
| namespace App\Models; | |||
Contributor
Author
There was a problem hiding this comment.
Esto deberíais haberlo borrado, no movido :)
| ## How to colaborate with the project | ||
| ### Install the pre-commit: | ||
| - From outside the machine: | ||
| - Run: composer install |
Contributor
Author
There was a problem hiding this comment.
Buena práctica, definición de readme, top
| @@ -0,0 +1,86 @@ | |||
| #!/bin/sh | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Top, es una opción.
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0"?> | |||
|
|
||
| public function __invoke(Request $request) | ||
| { | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
Una mejora, podría haber sido sacar todas estas validaciones fuera del controller para poder testarlo. Pero bueno esto ya es algo más top. Pero como idea os puede servir. De hecho, Laravel tiene un tema llamar CustomRequest al que se le pueden meter reglas de validación
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.